-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit Icons to Panel #26
Comments
I dont understand what is the problem.... |
The problem is if I set the dock to show large icons, as I do with Plank, they will fall off the screen when I open more apps. |
Can you upload a screenshot, to see the case? |
Oh... you mean that if icons reach the edges to shrink in size in order to not hide.... Right? |
BTW, if you want you can hide the panel background if you want to.... |
Yes
Yes, I appreciate the provided scripts for hacking the plasma theme into approximating a real dock, but I'm not bothering with that for now as I can't really use this unless I can resolve/hack-around the #27 problem. |
It would be cool to adjust icon size automatically in both directions: First, according to the width of the panel (also considering zoom factor) so this does not have to be set manually (no more need of the red line). [Actually it would be great to have two ways to adjust this: either modifying the width of the panel, so the icon size in the plasmoid follows; or just the other way around, setting the icon size of the plasmoid in settings, and the width of the panel follows]. Second, but also when the amount of tasks is too large, according to the length of the panel, so no icon is left behind. Does it sound reasonable? |
Yes, that sounds reasonable. I don't use zoom myself. I think the basic reasoning if you're basing icon size on panel dimensions is that the panel width should determine the maximum, or ideal/target icon size, and that the panel length and number of icons together further limit the actually presented icon size. If it is not based purely on panel dimensions, then the max/ideal is set by the icon size preference, then limited by panel width, panel length, and number of icons present. I think I just said what you said. |
please provide me with your feedback for the following. Use case, bottom panel (to be easy to understand what we are describing)
|
That sounds great to me |
Yeah, sounds perfect. |
please test [automatic branch] in Now Dock Panel for this, |
Automatic size works! However (there is always a however, sorry), it also seems to me that the space saved for zoom animation is overestimated. Fitting the size to the bare minimum is important as otherwise it narrows down space for window applications in the desktop. Actually, I recall adjusting the panel size manually before regardless of the red line, as it also overestimated the panel size in my system. |
On 09/09/2016 05:13 πμ, kupiqu wrote:
the zoomFactor+0.1 stands for length needed by launcher bounching animation
|
I see. I guess what happens is that I am of the opinion that the price to pay in desktop space is too big for the bouncing animation, and would like to have no margin for similar purposes, so my manual adjustment tried to fit to (zoomFactor * iconSize) Three observations to this (perhaps as options):
Related to point 2 above, I only see the margin being important when the scaling zoom is 0. In other words, I don't care much if I don't have any margin transiently while hovering or during bouncing behavior, but it is nice to have it while icons are at 'rest', and to have it scaled by the icon's size, in my opinion. |
scaling zoom 0, I suppose you mean 1. If margin is changed during the |
Yes, sorry I meant scaling factor equal to 1. I see, the margin is set the same in all 4 directions, but I was referring to the outside margin, i.e. the direction that separates the panel from the rest of the desktop. The other 3 are very important and I wouldn't touch them at all (or at most I would consider margins proportional to icon size to keep aspect ratio indep of icon size, but that's rather a minor thing). For this specific outside margin and depending on scaling factor:
Regarding proportional margins, they could be set to factor*Icon_size, where factor_size is in [0,1] and actually quite low (e.g., 0.1, so if icon size is 48 px, the margin is 4.8, which is similar to the current 5 px that you are using now). But please note that this doesn't mean that margins change dynamically during hovering, animation etc, I would just suggest to just use the icon size at rest for reference. |
Let's move this conversation to the right place... concerning the margins... the calculations look good but I have to test it also for sizes> 48 what is happening visually.... |
please, @AndydeCleyre @kupiqu check [master] branches for plasmoid and panel, I have decreased the space needed for animations (which was based on launcher's bounching) so this should give maximum size the icon's hovering size... |
The automatic scaling according to the new settings for spacing works nice, but I don't see hovering effects anymore on icons that are not part of nowdown-plasmoid yet are present in the nowdock-panel. |
Sorry, most of the previous behavior occurred just because I didn't lock my plasma desktop. Yet, something very weird still happens. Hovering effect only works on the top 'Earth' icon, not on the bottom one (see attachment). This plasmoid is to show a webapge and other than the specific webpage that is shown in each of the two, the two plasmoids are identical. |
I fixed that issue by removing and then adding the plasmoid back, so it doesn seem to be related to nowdock. Sorry for the noise |
please check for this from master branches for plasmoid and panel... I think it has been improved a lot!!! :) very complex piece of code this one, I had difficult time.... |
Yes, using master branches on both now, and they seem to work fine. |
@kupiqu just for clarify:
Reasons for not animating plasmoids in the panel:
|
@psifidotos Can you post instructions for properly installing the latest versions? I tried checking out the two repositories and symlinking them into Also, is there any point to my using nowdock-panel if I won't be using any zoom effects? |
Now Dock Panel layouts the plasmoids in different way from the default panel... even though you may not use the zoom factor (you can set it to 1 for no hovering animations), the now dock panel layouts them with more consistense. That is if you want to add plasmoids surrounding the now dock plasmoid. Installation instructions you download the master branches as tar.gz files for example and you are extracting them. a plasma panel is just a plasmoid with different behavior.... plasmapkg2 is the command to install and update plasmoids from the command line... |
I see, this is I think what happened. I must have locked it accidentally... |
Hi,
This is one of just two features that keep me from being able to take advantage of this much appreciated effort.
Please add an icon size mode that makes the icons as large as can fit on the panel.
The text was updated successfully, but these errors were encountered: