Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn PUF into pickle loader, drop global var definitions #11

Closed
iliakur opened this issue Aug 26, 2014 · 1 comment
Closed

Turn PUF into pickle loader, drop global var definitions #11

iliakur opened this issue Aug 26, 2014 · 1 comment

Comments

@iliakur
Copy link
Contributor

iliakur commented Aug 26, 2014

I think it makes sense to read in the variables we define in PUF from some sort of file. We currently have JSON and pickle at our disposal, so it's not like we're short on options.
This will make the code more readable (less scrolling through tedious variable definitions) and we can always choose a file format that's human-readable so that interested parties can inspect what variables we are loading.

Additionally, just like in issue #10 it would be nice to get rid of global variable definitions and replace them with a dictionary. It would make sense to merge this dictionary with the one we get from the PUF file.

@iliakur iliakur added this to the Working prototype milestone Aug 29, 2014
@iliakur iliakur self-assigned this Aug 29, 2014
@iliakur
Copy link
Contributor Author

iliakur commented Sep 29, 2014

Closing this, as we have the code for it but also may find another solution.

@iliakur iliakur closed this as completed Sep 29, 2014
@iliakur iliakur removed their assignment Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant