Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to flutter 2.2 (null-safe) #25

Closed
wants to merge 1 commit into from
Closed

Migrate to flutter 2.2 (null-safe) #25

wants to merge 1 commit into from

Conversation

zefhemel
Copy link

@zefhemel zefhemel commented Jun 8, 2021

This still leaves some deprecated APIs, but at least it builds ands seems to work. Bonus: also adds a macOS app to the example (used that for testing).

Most of this work is done by the migration tool, but had to tweak a few things here and there. It's possible more things have been marked as non-nullable than should be, please check.

@zefhemel zefhemel changed the title Migrate to flutter 2.0 (null-safe) Migrate to flutter 2.2 (null-safe) Jun 8, 2021
@mack-at-pieces
Copy link

Looking great! Excited to use this.

@mack-at-pieces
Copy link

mack-at-pieces commented Jun 18, 2021

hey @zefhemel we are trying to use this version in our app and are having problems getting the editor to build in Windows, Linux, and Android. We haven't tried iOS yet, but we are having success on MacOS so that's a good indicator.

Our setup is fairly simple:
Screen Shot 2021-06-18 at 11 48 35 AM

The error isn't very descriptive, but this is what we're seeing:
Screen Shot 2021-06-18 at 11 54 34 AM

Any thoughts on what might be happening?

@sluebbert
Copy link

If it helps at all, this is the first exception dumped right before I too get the 'child == _child' error on android:

════════ Exception caught by widgets library ═══════════════════════════════════
The following _CastError was thrown building RawGestureDetector-[LabeledGlobalKey<RawGestureDetectorState>#95e12](state: RawGestureDetectorState#f760f(gestures: <none>, excludeFromSemantics: true, behavior: opaque)):
Null check operator used on a null value

The relevant error-causing widget was
RichCodeField
When the exception was thrown, this was the stack
#0      _Editable.createRenderObject         :rich_code_editor/rich_editable_code.dart:1902
#1      RenderObjectElement.mount            :flutter/…/widgets/framework.dart:5430
...     Normal element mounting (75 frames)
#76     Element.inflateWidget                :flutter/…/widgets/framework.dart:3611
#77     Element.updateChild                  :flutter/…/widgets/framework.dart:3363
...

Seems like Null check operator used on a null value somewhere around rich_editable_code.dart:1902 may be upsetting it.

@psovit
Copy link
Owner

psovit commented Jun 1, 2022

Hi @zefhemel ,
Thanks for PR and my apologies for reviewing it so late.
Looks like lots of other changes have recently been added so I will have to review them, might consider creating a separate PR my self to support the latest Flutter changes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants