Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing remove(const char *path) #161

Closed
glebm opened this issue Nov 30, 2023 · 3 comments
Closed

Missing remove(const char *path) #161

glebm opened this issue Nov 30, 2023 · 3 comments

Comments

@glebm
Copy link
Contributor

glebm commented Nov 30, 2023

The remove function from stdio appears to be missing.

The implementation could probably be a wrapper around __set_errno(sceIoRemove(path)).

E.g. PS2 SDK does this:
https://github.com/ps2dev/ps2sdk/blob/6b656d1ae18dd2bb75a6caa03346cf9f933c12c6/ee/libcglue/src/glue.c#L576C17-L582

Whereas the PSP SDK currently stubs out the _unlink function (called by remove) to always fail:

pspsdk/src/libcglue/glue.c

Lines 603 to 608 in 2f723c3

#ifdef F__unlink
int _unlink(const char *path) {
errno = ENOSYS;
return -1; /* not supported */
}
#endif

@fjtrujy
Copy link
Member

fjtrujy commented Nov 30, 2023

Yes, you are right!
I will fix it today!

@fjtrujy
Copy link
Member

fjtrujy commented Nov 30, 2023

PR ready! #162

@glebm
Copy link
Contributor Author

glebm commented Dec 1, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants