Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying port for new bypass instance #25

Closed
cmwilhelm opened this issue Jul 28, 2016 · 1 comment
Closed

Specifying port for new bypass instance #25

cmwilhelm opened this issue Jul 28, 2016 · 1 comment

Comments

@cmwilhelm
Copy link
Contributor

cmwilhelm commented Jul 28, 2016

Hey, we've been working on standing up an Elixir application and found bypass a few days ago (great work, it's been very helpful so far!).

I was curious to know if there's been any interest / discussion about allowing users to specify a desired port to open a new Bypass on? We're using some libs that wrap http clients, but bake in their config at build time so the Application.put_env() model in your examples is a no-go for passing in the port Bypass.open assigns.

@alco
Copy link
Contributor

alco commented Jul 28, 2016

@cmwilhelm We haven't gotten any request for allowing this so far. And unfortunately Bypass does not permit passing it a specific port as is.

As a stop-gap solution, you could fork the project and change this code to get the value for port from the caller.

Long-term we would be OK with providing a public API to assign a fixed port to a Bypass instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants