Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The future of bypass #88

Closed
11 tasks done
ream88 opened this issue Mar 30, 2020 · 10 comments
Closed
11 tasks done

The future of bypass #88

ream88 opened this issue Mar 30, 2020 · 10 comments
Milestone

Comments

@ream88
Copy link
Collaborator

ream88 commented Mar 30, 2020

Hey everybody,

Today @MSch and I had a nice talk about the future of bypass. And we have awesome news to share: I will join the bypass team and help shape its future from now on! Of course @MSch and the rest of the awesome @PSPDFKit team aren't going anywhere, but for now I'll be the primary contact person for all your bypass related things.

For the start we want to clean up the backlog by releasing a new major version (2.0?). I want to collect all issues and improvements which should definitely be in the next major version into the list below.

If you have any ideas and suggestions, feel free to comment here!

All the best, and a happy Monday! 😊


Code and maintenance improvements:

Breaking changes:

New features:

@mhsdef
Copy link

mhsdef commented Mar 30, 2020

Yay! Props to you and @MSch both. Thanks for your efforts.

@lucacorti
Copy link

TLS support with automatic SSL certificates setup.

I need this to test my HTTP/2 implementation and would be willing to contribute.

@chrismcg
Copy link

chrismcg commented Apr 9, 2020

Thanks for taking this on. I love bypass and it's great to see it getting updated.

@ream88
Copy link
Collaborator Author

ream88 commented Apr 9, 2020

@chrismcg just give me a few more days, I want to go through all issues in the backlog! 😊

@chrismcg
Copy link

chrismcg commented Apr 9, 2020

@ream88 please don't take my comment as any kind of pressure to ship! I'm just happy to see a great lib get some love. I came here to see if there was a PR for the DynamicSupervisor deprecation warning so to see all the work that's been done in addition to that is great.

@agramichael
Copy link

@ream88 any possibility of making it so that within one test I can stack two expect_once's so that the first call to the given route gets my first expect_once and the second call gets the second expect_once?
Currently the second expect_once would just redefine the first expect_once and I would get an error because the route is called twice.

@ream88
Copy link
Collaborator Author

ream88 commented Apr 24, 2020

@agramichael Is #80 fixing this for you? Can you try out the master branch? 😊

@agramichael
Copy link

@ream88 that fix has been very helpful! But it's not quite what I was thinking. That allows users to redefine what the response is for the route but still doesn't allow setting multiple responses for the same route, and consuming them in order.

@mrdougwright
Copy link

@ream88 that fix has been very helpful! But it's not quite what I was thinking. That allows users to redefine what the response is for the route but still doesn't allow setting multiple responses for the same route, and consuming them in order.

I believe I'm having the exact same issue. We've added a Plug to our main controller that calls (and caches!) out to our graphql API. This now adds an extra call to all of our controller tests, which breaks their call expectations.

Since the route is the same, if we could set and check multiple responses for the same route, we could update our Bypass wrapper in one place.

@ream88
Copy link
Collaborator Author

ream88 commented May 10, 2020

@agramichael @mrdougwright I moved the conversation to a new issue: #95

@ream88 ream88 closed this as completed Aug 20, 2020
@ream88 ream88 unpinned this issue Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants