Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Wrong underlying API call for get_macd #14

Closed
svmlfin opened this issue Jun 12, 2023 · 2 comments
Closed

[Issue] Wrong underlying API call for get_macd #14

svmlfin opened this issue Jun 12, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@svmlfin
Copy link

svmlfin commented Jun 12, 2023

Though it is suggested to follow the below structure to file an issue, feel free to use your own way to file issues too. Just ensure you're providing adequate information about the issue. That's all we'd need :)

Describe the bug
In get_macd function in the base client, ema is being called as the underlying API.

_path = f'/v1/indicators/ema/{symbol.upper()}'

To Reproduce
Calling SyncStocksClient.get_macd and SyncStocksClient.ema give the same results

@svmlfin svmlfin added the Potential Bug Might be a bug, can't say for certain (yet) label Jun 12, 2023
@pssolanki111
Copy link
Owner

hey sorry for delay. Didn't get enough time due to my full time role. Thanks for the report.

I'll take a look and add it to the backlog

@pssolanki111 pssolanki111 self-assigned this Sep 21, 2023
@pssolanki111
Copy link
Owner

@svmlfin This is fixed in version 1.1.2. Commit: d90ce4b

Please upgrade the library (pip install --upgrade polygon)

@pssolanki111 pssolanki111 added bug Something isn't working and removed Potential Bug Might be a bug, can't say for certain (yet) labels Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants