Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the internal tmt executor by default #342

Merged
merged 1 commit into from Sep 16, 2020
Merged

Use the internal tmt executor by default #342

merged 1 commit into from Sep 16, 2020

Conversation

psss
Copy link
Collaborator

@psss psss commented Sep 8, 2020

It gives better information about test progress.
Supports interactive test debugging as well.

@psss psss added the execute Execute step label Sep 8, 2020
@psss psss self-assigned this Sep 8, 2020
@psss psss requested review from pvalena and thrix September 8, 2020 12:52
thrix
thrix approved these changes Sep 15, 2020
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope this will not break anything :)

@psss
Copy link
Collaborator Author

psss commented Sep 15, 2020

/packit test

@psss
Use the internal tmt executor by default
7e00840 
It gives better information about test progress.
Supports interactive test debugging as well.
Fix shell script option check in detach executor.
@psss psss merged commit 7e00840 into master Sep 16, 2020
@psss psss deleted the default-execute branch September 16, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@pvalena pvalena Awaiting requested review from pvalena

Assignees

@psss psss

Labels
execute Execute step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psss @thrix