New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VCR to catch peripheral availability requests in tests #1248

Open

ajkiessl opened this issue Nov 27, 2023 · 0 comments

Contributor

ajkiessl commented Nov 27, 2023

These tests will fail if they cannot connect to the sirsi url for availability information:

spec/features/search_bar_spec.rb
spec/features/book_covers_spec.rb
spec/features/single_item_publication_fields_spec.rb
spec/features/search_results_spec.rb
spec/features/basic_search_spec.rb
spec/features/bookmarks_spec.rb

The purpose of these tests is not to test a live connection to sirsi, so these requests should be mocked. Use VCR to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment