Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Date Attributes to Make More Effective Use of Pandas offset classes #9

Closed
seekinginfiniteloop opened this issue Dec 27, 2023 · 0 comments · Fixed by #10
Closed
Assignees
Labels
enhancement New feature or request

Comments

@seekinginfiniteloop
Copy link
Owner

seekinginfiniteloop commented Dec 27, 2023

Currently we use Pandas offsets as attributes, but we can improve both functionality and concision if we make more effective use of Pandas built-in offset classes, namely:

FedHoliday -- create a custom AbstractHolidayCalendar of Holiday objects instead of using prebuilt USFederalHolidayCalendar

FedBusDay -- evaluate directly subclassing CDay.

MilitaryPayDay -- combine offsets from FedBusDay/CDay and Semi-Month-Begin, or evaluate subclassing. We get it right we can simplify calculations to 'dates += MilitaryPayDay [or its attribute]'

passdays -- this one I'm less sure about. I suspect we can also use offset classes to build this and apply it as a direct offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant