Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopUp does not take the full size of the screen #5

Closed
gjgd opened this issue Dec 12, 2014 · 4 comments · Fixed by #6
Closed

PopUp does not take the full size of the screen #5

gjgd opened this issue Dec 12, 2014 · 4 comments · Fixed by #6
Assignees
Labels
Milestone

Comments

@gjgd
Copy link

gjgd commented Dec 12, 2014

Hello,

Thank you for your project, it will help me a lot ! However, I do have a problem.
I have copied your sample code in my project, but when I try to run it on a simulator, the popUp does not take the full size of the screen. There is some white space on the bottom and the right side (see picture attached).

What should I do to fix it ?
I am on Xcode 6.1.1, and am building on iOS 8.1

Cheers,
screen shot 2014-12-12 at 11 24 43

@gjgd
Copy link
Author

gjgd commented Dec 12, 2014

The weird thing is, in my project, this bug appears only for iPhone 6/iPhone 6 Plus.

@psy2k psy2k added the bug label Dec 12, 2014
@psy2k
Copy link
Owner

psy2k commented Dec 12, 2014

@dardelet Thats an issue with autolayout and bigger screens. I will fix it as soon as possible.

@psy2k psy2k self-assigned this Dec 12, 2014
@psy2k
Copy link
Owner

psy2k commented Dec 13, 2014

@dardelet I've updated the project with .xib files for the bigger screen iPhones. Example View Controller code is also updated to reflect those changes. Download the project again (or perform a git pull if you cloned it using git).

@psy2k psy2k closed this as completed in #6 Dec 13, 2014
@gjgd
Copy link
Author

gjgd commented Dec 13, 2014

Works like a charm, thank you !

@psy2k psy2k added this to the v2.1 milestone Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants