Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML comments escaped in output #54

Closed
BenLubar opened this issue Mar 4, 2016 · 2 comments
Closed

HTML comments escaped in output #54

BenLubar opened this issue Mar 4, 2016 · 2 comments

Comments

@BenLubar
Copy link

BenLubar commented Mar 4, 2016

For example, <!-- foo --> turns into &lt;!-- foo --&gt; in the output even though other HTML tags are passed through unchanged.

BenLubar added a commit to BenLubar/nodebb-plugin-htmlcleaner that referenced this issue Mar 5, 2016
@codecowboy
Copy link

How do we do block comments?

I tried:

{*      <span class="post-tools">
            <a component="post/reply" href="#" class="no-select <!-- IF !privileges.topics:reply -->hidden<!-- ENDIF !privileges.topics:reply -->">[[topic:reply]]</a>
            <a component="post/quote" href="#" class="no-select <!-- IF !privileges.topics:reply -->hidden<!-- ENDIF !privileges.topics:reply -->">[[topic:quote]]</a>
        </span>*}

but the curly brace and asterisk are rendered.

@pitaj
Copy link
Member

pitaj commented Aug 26, 2017

you can use regular old HTML comments now as long as they don't start with IF, BEGIN, or END

@pitaj pitaj closed this as completed Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants