Remove obsolete and incorrect FreeBSD version condition #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FreeBSD-related condition which enables custom round() implementation is incorrect: one must include <sys/param.h> to get __FreeBSD_version value, and since it's not included here, the check succeeds while it shouldn't. Before it worked somehow, but since python 3.7 it results in conflicting declarations of round(). The condition is also no longer needed since FreeBSD 5.3 is unsupported for 12 years.
|
Thank you for this. Do you know if it's possible to set up a CI system for BSD? |
|
If you mean public CI service like Travis, there are none that I know of, unfortunately. Self hosting is always available with any opensource CI system, but maintaining this would be time wasting IMO. You could also just set a FreeBSD (or other BSD) VM and test your code there occasionally. |
|
@AMDmi3 self-hosting is not anything I fancy doing, no. As well as having my own VM. So this patch will be merged without further QA. |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeBSD-related condition which enables custom
round()implementation is incorrect: one must include<sys/param.h>to get__FreeBSD_versionvalue, and since it's not included here, the check succeeds while it shouldn't. Before it worked somehow, but since python 3.7 it results in conflicting declarations ofround(). The condition is also no longer needed since FreeBSD 5.3 is unsupported for 12 years.This change thus fixes build of psycopg with python 3.7 on FreeBSD.