Make pycanberra work with both Python 2 and 3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python 2, it is imported automatically, so there really isn't any
need to import it, it's classes can be used directly:
$ python2
>>> e = Exception()
>>> import exceptions
>>> isinstance(e, exceptions.Exception)
True
Also, it doesn't exist on Python 3, so removing it will make the port
easier.
|
I think patch 2 and 3 should be simplified: canberra properties should be plain strings without doing the "six" conversion there. The "six" conversion should be done on the fly when calling the function for all the arguments |
|
Agreed, I just dropped the second patch then, as the third one already implemented what you asked. |
We need to pass byte strings to libcanberra, which is default with Python 2 when defining a string as "foo". However, on Python 3, the same definition gives a unicode string, which libcanberra can't handle. To avoid forcing applications to change the way they called pycanberra on Python 2, pycanberra now quickly ensures that all strings it handles are encoded to bytes, if they weren't already.
|
Patch updated to drop the dependency on |
totdb
added a commit
that referenced
this pull request
May 15, 2013
Make pycanberra work with both Python 2 and 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just clean up, it removes something that already wasn't needed in Python 2. However, from unneeded in Python 2, it becomes problematic in Python 3, so it should be dropped.
The second commit makes pycanberra work on Python 3, using the six library to keep it compatible with Python 2.
The issue is on strings defined as
"foo"which were byte strings in Python 2 but became unicode strings in Python 3.The underlying C libcanberra doesn't accept unicode strings, so they all must be byte strings.
However, defining them with
b"foo"would break them on Python 2, so I usedsix.b("foo")instead.If the dependency on
sixis an issue, then we could just copy-paste the code forsix.bin pycanberra. (but code duplication is bad, so I preferred using the module as a dependency in the first submission 馃槈)