LPS-137025 Validate/Create fields rules to Business Info - Info Panel #123

jairmedeiros · 2021-08-09T15:16:45Z

LPS-137025 Create hook to get Legal Entities
LPS-137025 Add new inputs to attend the mock
LPS-137025 Add First Select option for non Default Values
LPS-137025 Adjust placeholder to add the percentage
LPS-137025 Fix defaultValue prop to Select and Switch
LPS-137025 Add Default Values to ControlledSwitch
LPS-137025 Fix Legal Entities list
LPS-137025 Add new REGEX to validate percentage until 100
LPS-137025 Export getCategoryProperties instead getBusinessClassCode
LPS-137025 Save segment in form's value
LPS-137025 Validate BCC and Segment to show some fields
LPS-137025 Fix Step Percentage to Business field
LPS-137025 Fix indentations
LPS-137025 Centralize logic to businessFields
LPS-137025 Remove default value for placeholder parameter in InputWithMask
LPS-137025 Remove option hidden for Select atom
LPS-137025 Pass pattern within rules prop

… list

liferay-continuous-integration · 2021-08-09T15:16:49Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

kevenleone · 2021-08-09T16:52:33Z

Just starting reviewing :)

kevenleone

@jairmedeiros my dear!

At first, congratulations for the PR, everything is amazing! 🎉

It's really, really good!

I did some considerations for your code, but, I would like to get some advices from @joseabelenda and @giu7d to merge this code.

But for me, it could be merged.

kevenleone · 2021-08-09T17:04:32Z

...nitializer/remote-web-components/raylife-d2c-web/src/components/containers/Forms/Business.js

@@ -48,6 +48,7 @@ export const FormBusiness = () => {
          label="Do you store personally identifiable information about your customers?"
          rules={{ required: true }}
          control={control}
+          defaultValue="true"


Hey @jairmedeiros , I noted that here defaultValue is true, as string

@kevenleone this is required to prevent the DOM to think a boolean is been used as an attribute... which could lead to unexpected behavior.

I suggest that if we want to remove the "true"/"false" as strings to improve the code readability that we change the name... but still, it needs to be a string.

Also, the isValid will think the field is not valid if it has the false as a boolean value. Maybe we should just change this to "yes" or "no" to avoid this problem at all...

kevenleone · 2021-08-09T17:05:27Z

...nitializer/remote-web-components/raylife-d2c-web/src/components/containers/Forms/Business.js

@@ -80,6 +81,7 @@ export const FormBusiness = () => {
          label="Do you sell products under your own brand or label?"
          rules={{ required: true }}
          control={control}
+          defaultValue={false}


But here, defaultValue is false as boolean.

That's the idea, or should everything be a string or boolean?

This should be a string...

I put false, because following the mock, this field doesn't have a default value. When a remove this parameter the field stay with "no" selected by default. How can I do it right? ty.

kevenleone · 2021-08-09T17:10:36Z

...-insurance-site-initializer/remote-web-components/raylife-d2c-web/src/hooks/useStepWizard.js

+
+  const businessTotalFields = (properties) => {
+    let fieldCount = 4;
+    const bccAllowedToField = ["750", "1349"];


I think in the future, we can't assign this value as fixed, right @joseabelenda ?

Maybe a way to workaround this, should make another request for categorization api?

Is there a request that return the BCCs allowed for appear some fields? I was following the spreadsheet where some fields only appears when the product's BCC is 750 or 1349, for example.

It's ok @jairmedeiros , I think we don't have this for now

kevenleone · 2021-08-09T17:11:48Z

...insurance-site-initializer/remote-web-components/raylife-d2c-web/src/utils/businessFields.js

@@ -0,0 +1,21 @@
+export const BCC_ALLOWED = {
+    PERCENT_SALES: ["750", "1349"],


For now it's okay, but the same from previous: this should be dynamic in the future, isn't @joseabelenda ?

giu7d · 2021-08-09T17:31:34Z

...components/raylife-d2c-web/src/components/connectors/Controlled/Input/WithMask/Percentage.js

-          value: PERCENTAGE_REGEX,
-          message: "Must be a valid percentage",
-        },
+        pattern,


Just a suggestion, a pattern will always be overwritten by a rule...

So if I do:

<PercentageControlledInput pattern={...something} rule={{ pattern: { ...something2 }}} />

The pattern={...something} will never be used.

I suggest you keep the old structure to use a component that extends the react-hook-form semantic and prevents unnecessary props.

giu7d · 2021-08-09T17:35:06Z

...nitializer/remote-web-components/raylife-d2c-web/src/components/containers/Forms/Business.js

@@ -48,6 +48,7 @@ export const FormBusiness = () => {
          label="Do you store personally identifiable information about your customers?"
          rules={{ required: true }}
          control={control}
+          defaultValue="true"


@kevenleone this is required to prevent the DOM to think a boolean is been used as an attribute... which could lead to unexpected behavior.

I suggest that if we want to remove the "true"/"false" as strings to improve the code readability that we change the name... but still, it needs to be a string.

Also, the isValid will think the field is not valid if it has the false as a boolean value. Maybe we should just change this to "yes" or "no" to avoid this problem at all...

giu7d · 2021-08-09T17:42:15Z

...nitializer/remote-web-components/raylife-d2c-web/src/components/containers/Forms/Business.js

+              value: "salesMerchandise",
+            }}
+            control={control}
+            pattern={{


Is there a reason for this pattern not to be a default rule of the PercentageControlledInput?

Also, I think it should be used as part of the rules prop to keep the react-hook-form semantic:

<PercentageControlledInput ... rules={{ pattern={ ...something } }} />

There is no reason haha. I thought to keep for reuse where to be required a percentage field with more than 100%. I will fix it to pass within the rules props.

giu7d · 2021-08-09T17:54:51Z

...lizer/remote-web-components/raylife-d2c-web/src/components/fragments/Forms/Input/WithMask.js

@@ -12,6 +12,7 @@ export const InputWithMask = React.forwardRef(
      error,
      allowNegative = false,
      required = false,
+      placeholder = "",


Placeholder attribute was already handled by the ...props

Understood, I will fix it too!

giu7d · 2021-08-09T18:07:15Z

...e-initializer/remote-web-components/raylife-d2c-web/src/components/fragments/Forms/Select.js

@@ -21,6 +21,7 @@ export const Select = React.forwardRef(
          className="input"
          required={required}
        >
+          <option hidden>Select</option>


I think you should not add this to the Select atom.

The Select fragment is an atomic component that represents a pure select input reusable by any component. Logic belongs outside the fragment as a connector or container component.

I would move the <option hidden>Select</option> were it is needed.

giu7d · 2021-08-09T18:13:07Z

...nitializer/remote-web-components/raylife-d2c-web/src/components/containers/Forms/Business.js

@@ -80,6 +81,7 @@ export const FormBusiness = () => {
          label="Do you sell products under your own brand or label?"
          rules={{ required: true }}
          control={control}
+          defaultValue={false}


This should be a string...

kevenleone

Hi @jairmedeiros , looking into @giu7d comments, can you do changes where is needed?

…hMask

giu7d

Good job @jairmedeiros! I think it is good to go 😄

kevenleone

Looks good to me 🔥

Thank you guys, @giu7d , @jairmedeiros

kevenleone · 2021-08-10T21:04:59Z

Just starting reviewing :)

kevenleone · 2021-08-10T21:11:47Z

resent: #131

joseabelenda and others added 30 commits August 8, 2021 11:43

LPS-135660 Change Classic theme by Solution theme

4e6d377

LPS-135662 Create business home cover

7c696e6

LPS-135663 create our philosophy fragment

0713ff8

LPS-135948 Create Get a Quote Page

ab023e4

LPS-135948 Create Quote NavBar Fragment

0e6ea2e

LPS-135951 Create Quote Page Template

310e4f2

LPS-135948 Change Public template by Public Quote template

f3278c2

LPS-135660 Add more tokens to Style Books

3629a98

LPS-135948 SF

24328cc

LPS-135715 Create Asset Category hierarchy with the Raylife properties

1f6479f

LPS-136030 Update Business Home Cover Styling and Logic

813c47d

LPS-136029 Create Get a Quote Footer

eba32c3

LPS-135717 Create ObjectDefinitionSampleGenerator

972a79c

LPS-136029 SF

b8d5dfb

LPS-136019 Improve Public Navbar fragment

279703d

LPS-135717 Add sample data using Liferay Object

54746ec

LPS-135645 Raylife D2C Code

c508f11

LPS-135645 SF

c7b7ede

LPS-135717 Remove ObjectDefinitionSampleGenerator

304cf83

LPS-135950 Improve Quote NavBar Fragment

5e58937

LPS-135716 Add commerce dependencies

69c71d2

LPS-135716 Create importCPDefinitions methods passing assetCategories…

96d9e56

… list

LPS-135716 Add methods to create commerce structures

ef9cac8

LPS-135716 add external reference in json

640e9f1

LPS-135716 Create json files in resources

e659ace

LPS-135716 Fix

31c6456

LPS-135716 SF

eb7faee

LPS-136251 Update Thumbnail

66de1c7

LPS-136252 Update font-size for Fields

4960129

LPS-136252 Add Missing Options for Product Select

6a33404

Jair Medeiros added 11 commits August 9, 2021 12:15

LPS-137025 Adjust placeholder to add the percentage

b0a2afe

LPS-137025 Fix defaultValue prop to Select and Switch

05cbf0e

LPS-137025 Add Default Values to ControlledSwitch

b905367

LPS-137025 Fix Legal Entities list

9dec97e

LPS-137025 Add new REGEX to validate percentage until 100

0a0c5fa

LPS-137025 Export getCategoryProperties instead getBusinessClassCode

0e12f89

LPS-137025 Save segment in form's value

0be3388

LPS-137025 Validate BCC and Segment to show some fields

ee7e991

LPS-137025 Fix Step Percentage to Business field

5330dbf

LPS-137025 Fix indentations

b088b71

LPS-137025 Centralize logic to businessFields

84efb75

joseabelenda requested a review from kevenleone August 9, 2021 15:31

kevenleone added the Fragment label Aug 9, 2021

kevenleone approved these changes Aug 9, 2021

View reviewed changes

giu7d suggested changes Aug 9, 2021

View reviewed changes

kevenleone self-requested a review August 9, 2021 18:33

kevenleone requested changes Aug 9, 2021

View reviewed changes

Jair Medeiros added 3 commits August 10, 2021 09:40

LPS-137025 Remove default value for placeholder parameter in InputWit…

1fd1fa1

…hMask

LPS-137025 Remove option hidden for Select atom

3317def

LPS-137025 Pass pattern within rules prop

9243257

giu7d approved these changes Aug 10, 2021

View reviewed changes

kevenleone approved these changes Aug 10, 2021

View reviewed changes

joseabelenda force-pushed the raylife branch from bb09881 to 332ff00 Compare August 10, 2021 21:07

kevenleone closed this Aug 10, 2021

jairmedeiros deleted the LPS-137025 branch January 20, 2022 01:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-137025 Validate/Create fields rules to Business Info - Info Panel #123

LPS-137025 Validate/Create fields rules to Business Info - Info Panel #123

jairmedeiros commented Aug 9, 2021 •

edited

liferay-continuous-integration commented Aug 9, 2021

kevenleone commented Aug 9, 2021

kevenleone left a comment •

edited

kevenleone Aug 9, 2021

giu7d Aug 9, 2021 •

edited

kevenleone Aug 9, 2021

giu7d Aug 9, 2021

jairmedeiros Aug 10, 2021

kevenleone Aug 9, 2021

jairmedeiros Aug 10, 2021

kevenleone Aug 10, 2021

kevenleone Aug 9, 2021

giu7d Aug 9, 2021

jairmedeiros Aug 10, 2021

jairmedeiros Aug 10, 2021

giu7d Aug 9, 2021 •

edited

giu7d Aug 9, 2021

jairmedeiros Aug 10, 2021 •

edited

jairmedeiros Aug 10, 2021

giu7d Aug 9, 2021

jairmedeiros Aug 10, 2021

jairmedeiros Aug 10, 2021

giu7d Aug 9, 2021

jairmedeiros Aug 10, 2021

jairmedeiros Aug 10, 2021

giu7d Aug 9, 2021

kevenleone left a comment

giu7d left a comment

kevenleone left a comment

kevenleone commented Aug 10, 2021

kevenleone commented Aug 10, 2021

		@@ -0,0 +1,21 @@
		export const BCC_ALLOWED = {
		PERCENT_SALES: ["750", "1349"],

LPS-137025 Validate/Create fields rules to Business Info - Info Panel #123

LPS-137025 Validate/Create fields rules to Business Info - Info Panel #123

Conversation

jairmedeiros commented Aug 9, 2021 • edited

liferay-continuous-integration commented Aug 9, 2021

kevenleone commented Aug 9, 2021

kevenleone left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giu7d Aug 9, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giu7d Aug 9, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jairmedeiros Aug 10, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevenleone left a comment

Choose a reason for hiding this comment

giu7d left a comment

Choose a reason for hiding this comment

kevenleone left a comment

Choose a reason for hiding this comment

kevenleone commented Aug 10, 2021

kevenleone commented Aug 10, 2021

jairmedeiros commented Aug 9, 2021 •

edited

kevenleone left a comment •

edited

giu7d Aug 9, 2021 •

edited

giu7d Aug 9, 2021 •

edited

jairmedeiros Aug 10, 2021 •

edited