Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-138930 Impedibug Alignment Issues When Address is Long #232

Merged

Conversation

RodrigoCavalcantii
Copy link

No description provided.

@RodrigoCavalcantii RodrigoCavalcantii added Frontend Indicates the PRs made by Solutions' frontend team Raylife D2C Raylife Direct to Customer Project (site-initializer-raylife-d2c) Review needed labels Sep 8, 2021
@RodrigoCavalcantii RodrigoCavalcantii self-assigned this Sep 8, 2021
Copy link
Collaborator

@kevenleone kevenleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevenleone
Copy link
Collaborator

Grande @RodrigoCavalcantii, tá muito bom sua mudança meu nobre, obrigadoO!!

Só um ponto de atenção, esse commit: Impedibug Missing a word in one of the questions

Ele não tem o TICKET como prefixo, é mandatório para pull requests e commits que vão para a master do Liferay, como esse não é nosso caso, eu vou mergear assim mesmo, certo?

É bom para nós mesmos do time saber de qual ticket surgiu aquele mudança, para nos guiarmos

@kevenleone kevenleone merged commit f341c98 into is-solutions-delivery:raylife Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Indicates the PRs made by Solutions' frontend team Raylife D2C Raylife Direct to Customer Project (site-initializer-raylife-d2c)
Projects
None yet
2 participants