Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about dev-mode? in readme and changelog? #73

Open
timmc opened this issue May 20, 2016 · 1 comment
Open

Warn about dev-mode? in readme and changelog? #73

timmc opened this issue May 20, 2016 · 1 comment

Comments

@timmc
Copy link

timmc commented May 20, 2016

I know the library is EOL, but could you add a warning to the README about dev-mode? so that people will turn it off in production?

I just discovered that one of our servers was experiencing periodic hangs due to threads blocked on re-reading the jar file every time a translation was needed. This might no longer be relevant in v3 -- I couldn't quite tell from the changelog -- but the server uses v2.0.1 and this took some time to debug since dev-mode isn't documented.

The README currently implies that dev-mode is off by default ("Enable the :dev-mode? option and you're good to go!"; various places where it is shown as explicitly enabled) -- a "hey, turn this off in prod" would be great.

I could send a PR if that would be helpful.

@ptaoussanis
Copy link
Member

Hi Tim, sorry about that!

The README currently implies that dev-mode is off by default

My apologies, the default does appear to be on by default (incl. for the latest release). Would definitely be up for a README PR.

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants