Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return value in base conversion API #508

Closed
mountaindude opened this issue Jun 21, 2022 · 0 comments · Fixed by #513
Closed

Incorrect return value in base conversion API #508

mountaindude opened this issue Jun 21, 2022 · 0 comments · Fixed by #513

Comments

@mountaindude
Copy link
Collaborator

mountaindude commented Jun 21, 2022

The last return be a return null.

        if (request.query.base62 === undefined) {
            // Required parameter is missing
            reply.send(httpErrors(400, 'Required parameter missing'));
        } else {
            const base16 = base62_to_Hex(request.query.base62);
            return { base62: request.query.base62, base16 };
        }

        return {
            response: 'Butler reporting for duty',
            butlerVersion: globals.appVersion,
        };
@mountaindude mountaindude changed the title Unreachable code in base conversion API Incorrect return value in base conversion API Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant