Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelPrinter.Render always goes to stdout #613

Closed
rafaelespinoza opened this issue Jan 15, 2024 · 2 comments · Fixed by #614
Closed

PanelPrinter.Render always goes to stdout #613

rafaelespinoza opened this issue Jan 15, 2024 · 2 comments · Fixed by #614
Assignees
@MarvinJWendt
Labels
bug Something isn't working

Comments

@rafaelespinoza
Copy link

rafaelespinoza commented Jan 15, 2024 •
edited

I noticed that for type PanelPrinter, its Render method always writes to standard output, and never to the .Writer field. All of the other Render for printer types write to the .Writer.

Is there any good reason for this? Can we change it so that its behavior is consistent with the Render methods for other printer types? Thanks
@rafaelespinoza rafaelespinoza added the bug Something isn't working label Jan 15, 2024
@MarvinJWendt MarvinJWendt self-assigned this Jan 15, 2024
@MarvinJWendt
Copy link
Member

I'll take a look!

@MarvinJWendt MarvinJWendt linked a pull request Jan 17, 2024 that will close this issue
fix: PanelPrinter ignored the set Writer #614
Merged
@MarvinJWendt
Copy link
Member

Fixed in #614, will be released in the next couple minutes.
Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarvinJWendt MarvinJWendt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: PanelPrinter ignored the set Writer pterm/pterm
2 participants
@rafaelespinoza @MarvinJWendt