Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: check OS architecture #158

Closed
Linux123123 opened this issue Feb 1, 2021 · 3 comments · Fixed by #173
Closed

panel: check OS architecture #158

Linux123123 opened this issue Feb 1, 2021 · 3 comments · Fixed by #173
Labels
bug Something isn't working panel panel

Comments

@Linux123123
Copy link
Member

Linux123123 commented Feb 1, 2021

Describe the bug
The script can be run on other architectures then x86_64, even though MariaDB only supports x86_64.

To Reproduce
Steps to reproduce the behaviour:

  1. Run the script on 32 bit machine
  2. The script tries to install MariaDB and can't

Expected behaviour
It should check if the OS is x86_64 and disallow other architectures.

OS (please complete the following information):

  • OS: all
  • Installation: panel (wings already checks)

Additional context

[error] The MariaDB Repository supports these Linux OSs, on x86-64 only:
    * RHEL/CentOS 7 & 8
    * Ubuntu 16.04 LTS (xenial), 18.04 LTS (bionic), & 20.04 LTS (focal)
    * Debian 9 (stretch) & 10 (buster)
    * SLES 12 & 15
[error] See https://mariadb.com/kb/en/mariadb/mariadb-package-repository-setup-and-usage/#platform-support```
@vilhelmprytz vilhelmprytz added bug Something isn't working panel panel labels Feb 21, 2021
@vilhelmprytz
Copy link
Member

Thank you for reporting this. This is definitely not intended behaviour. Can we fetch CPU architecture without using virt-what?

@Linux123123
Copy link
Member Author

We already have this in wings install.

  MACHINE_TYPE=$(uname -m)
  if [ "${MACHINE_TYPE}" != "x86_64" ]; then # check the architecture
    print_warning "Detected architecture $MACHINE_TYPE"
    print_warning "Using any other architecture than 64 bit (x86_64) will cause problems."

    echo -e -n  "* Are you sure you want to proceed? (y/N):"
    read -r choice

    if [[ ! "$choice" =~ [Yy] ]]; then
      print_error "Installation aborted!"
      exit 1
    fi
  fi

It doesn't use virt-what for this part.

@vilhelmprytz
Copy link
Member

We already have this in wings install.

  MACHINE_TYPE=$(uname -m)
  if [ "${MACHINE_TYPE}" != "x86_64" ]; then # check the architecture
    print_warning "Detected architecture $MACHINE_TYPE"
    print_warning "Using any other architecture than 64 bit (x86_64) will cause problems."

    echo -e -n  "* Are you sure you want to proceed? (y/N):"
    read -r choice

    if [[ ! "$choice" =~ [Yy] ]]; then
      print_error "Installation aborted!"
      exit 1
    fi
  fi

It doesn't use virt-what for this part.

Ah, my bad, got a little confused. Yes, that could definitely be used!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working panel panel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants