Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Database Host Function #267

Closed
Ferks-FK opened this issue Dec 1, 2021 · 2 comments · Fixed by #277
Closed

Creating a Database Host Function #267

Ferks-FK opened this issue Dec 1, 2021 · 2 comments · Fixed by #277
Labels
wings wings

Comments

@Ferks-FK
Copy link

Ferks-FK commented Dec 1, 2021

[ Explanation ]

I would like to suggest an edit to the wings installation script.

Recently it was implemented the option for you to create the user for the database host creation automatically.

[ How it currently works ]

An option appears to choose whether or not you want a database host user.
If they choose "Yes", they will be prompted for a user and password, and that is it.

[ How it could work ]

Before the "User" and "Password" questions appear, ask the user whether the host will be functional only locally, or externally.

[ Examples: ]

Would you like to create your database host automatically? "Yes"
Will your host be accessible Locally, or externally? ( Local/External )

If the answer is "Local", do it the original way.
If "External", ask for the host IP.

[ Why this change? ]

Well, the script will not be limited to always creating hosts locally, and it will have an option for this to work in both cases.

@vilhelmprytz
Copy link
Member

Thank you for submitting this and sorry for the delay!

When you refer to the local/external database user, are you referring to changing the 127.0.0.1 part of this line?
https://github.com/vilhelmprytz/pterodactyl-installer/blob/06c0bda09fa1fb0fe8f179729236595a3f979bf3/install-wings.sh#L472

@Ferks-FK
Copy link
Author

Ferks-FK commented Dec 5, 2021

Thank you for submitting this and sorry for the delay!

When you refer to the local/external database user, are you referring to changing the 127.0.0.1 part of this line?

https://github.com/vilhelmprytz/pterodactyl-installer/blob/06c0bda09fa1fb0fe8f179729236595a3f979bf3/install-wings.sh#L472

Yes, and of course, we can't forget the configuration of my.cnf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wings wings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants