Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Let's Encrypt --nginx over standalone webserver #88

Closed
vilhelmprytz opened this issue Aug 14, 2020 · 5 comments · Fixed by #100
Closed

Use Let's Encrypt --nginx over standalone webserver #88

vilhelmprytz opened this issue Aug 14, 2020 · 5 comments · Fixed by #100
Assignees
@Linux123123
Labels
new feature Introduces a new feature

Comments

@vilhelmprytz
Copy link
Member

Is your feature request related to a problem? Please describe.
The standalone webserver option could cause problems later on for renewals, since then nginx is running and occupying the HTTP/HTTPS ports.

Describe the solution you'd like
Since certbot does support nginx it would be better to use certbot --nginx.

Describe alternatives you've considered
None.

Additional context
Mentioned in the Discord server.
@vilhelmprytz vilhelmprytz added the new feature Introduces a new feature label Aug 14, 2020
@Linux123123 Linux123123 mentioned this issue Aug 29, 2020
Closed
@vilhelmprytz
Copy link
Member Author

Waiting for #91 to be merged before working on this.

@Linux123123
Copy link
Member

Is the title correct here? Isn't the option --nginx. I think there is no such option --certbot. Of course correct me if I am wrong.

@Linux123123 Linux123123 mentioned this issue Oct 2, 2020
Closed
@Linux123123 Linux123123 mentioned this issue Oct 12, 2020
Merged
@vilhelmprytz vilhelmprytz changed the title Use Let's Encrypt "--certbot" over standalone webserver Use Let's Encrypt --nginx over standalone webserver Nov 4, 2020
@vilhelmprytz
Copy link
Member Author

Is the title correct here? Isn't the option --nginx. I think there is no such option --certbot. Of course correct me if I am wrong.

Fixed.

@Linux123123
Copy link
Member

Linux123123 commented Nov 4, 2020 •
edited

Also this should be assigned to me 👍

(because basically I have already done this)

@vilhelmprytz
Copy link
Member Author

Also this should be assigned to me

(because basically I have already done this)

Fixed. I have yet had the time to review your PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Linux123123 Linux123123

Labels
new feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

panel: Reorder, fixes, certbot with --nginx
2 participants
@vilhelmprytz @Linux123123