New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0-rc.3 corrupting server.properties #2308
Comments
Can confirm I have the exact same issue. Typically happens after a server restart. |
Please post the actual file contents and not a picture if you don't mind, can't exactly copy and paste from an image. |
Providing some insight here as the OP hasn't responded as this seems like a major issue. Special characters seem to be encoded after a server restart. This might be due to the way the egg rewrites the This seems to occur when I edit the file via Take a look at the below screenshots and text blobs: Before restart: After restart: I am running the latest version of Panel and Wings Please let me know if you require any additional information @DaneEveritt. |
@gabefraser see #2192 (comment) To my knowledge your specific issue is not a bug with Pterodactyl at all, because even an egg that doesn't modify any of the configuration files still ends up with that messed up output for some reason. |
Makes sense. Thanks for the follow up. |
@gabefraser you can confirm that is the case by disabling all of the config stuff for the egg (e.g. empty |
@Technofied can you please do the same thing, disabling any config modification for the specific egg, and attempting to start the server. If the MOTD is still messed up it is likely not an issue with Pterodactyl. |
That seems to have fixed it! |
Well, if that fixed it then that is tragic because that means it is indeed something with Pterodactyl most likely. I'll have to test this against a file that the game doesn't touch, because |
On a side note, this issue exists not only in rc3 but also in prior versions. I stumbled across this some weeks ago but thought it might be a spigot issue. |
It seems to be an issue with the game server not realizing its a utf-8 encoded file, thus leading to issues. Its certainly caused by the server itself touching the file I believe, but is a result of Pterodactyl writing the contents and the file ending up as not utf-8? Perhaps? I'm a little baffled to be honest. |
It seems to be trying to escape any existing unicode characters with more unicode, two servers on two different boxes same problem.
|
Yeah, I'm quite sure it's the game itself doing that but Pterodactyl is saving the file in a format that makes the server not realize it should be utf8. |
I think the problem may be that wings is parsing the original \u00A7 into the utf8 character § , then when it comes to writing it, placing the character § back into the file, instead of the original escaped code, likely hitting this bug https://bugs.mojang.com/browse/MC-2215 (Both of my servers are 1.12.2 forge with sponge) A solution could be to simply re \uify the values
|
^ Either that, or wait for mojang to fix the issue ^^. |
No, wings shouldn't be modifying the contents of files for unrelated lines, and it won't be backported anyway. |
Oops, yea, I didn't read the last replies properly, sorry. |
Wings has to rewrite the entire file to disk which requires decoding and then re-encoding it. There is no way around that process. The only work around for this is to disable the config parser on the egg so that wings doesn't even look at the file. This shouldn't be difficult to fix. |
The problem is that it's decoding escaped chars which causes this, (thanks golang... https://blog.golang.org/normalization ) |
Background (please complete the following information):
Describe the bug
A clear and concise description of what the bug is.
Please provide additional information too, depending on what you have issues with:
Panel:
php -v
PHP 7.3.21-1+ubuntu20.04.1+deb.sury.org+1 (cli) (built: Aug 7 2020 14:44:37) ( NTS )Daemon:
uname -a
anddocker info
(your kernel version and information regarding docker)Linux panel 5.4.0-42-generic #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
A regular long MOTD gets split and randomly chucked across the server.properties file. Even after fixing it so its back on one line it breaks and gets thrown across again
To Reproduce
Steps to reproduce the behavior:
Just have a motd that's all on one line, upgrade to 1.0 then see it get thrown across the file.
Expected behavior
A clear and concise description of what you expected to happen. If applicable, add screenshots or a recording to help explain your problem.
Motd to stay on one line after saving and especially after restarts
See attached image of issue below:
The text was updated successfully, but these errors were encountered: