Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Window Icon #43

Closed
Guillaume227 opened this issue Feb 8, 2023 · 4 comments
Closed

Application Window Icon #43

Guillaume227 opened this issue Feb 8, 2023 · 4 comments

Comments

@Guillaume227
Copy link
Contributor

Based on that (old-ish) imgui issue: ocornut/imgui#2715
I am wondering whether providing a way to display a main window icon should be part of what the battery-included, cross platform hello_imgui approach should offer.

I have looked at the doc and the hello_imgui_app example but it's not obvious how to achieve that currently.

@pthom
Copy link
Owner

pthom commented Feb 9, 2023

Application icon and window is inherently handled wildly differently on different platforms.

  • On windows, you can set it by using code
  • On MacOS, iOS, Android you have to provide the icon an the application bundle (i.e a set of resources that come with the app)
  • On Linux this is also handled at the Window manager level + may be by code

The expected icon file format also differs wildly (bmp, icns, etc)

The expected icon size and the number of expected variations also differs (Android may ask up to 6 variations IIRC).

@Guillaume227
Copy link
Contributor Author

Ok - I naively thought it was more standardized. Maybe the case for providing an example for each platform that new comers like me can just use as a template? In any case, we can close this issue.

@pthom pthom added wontfix This will not be worked on and removed wontfix This will not be worked on labels Sep 6, 2023
@pthom
Copy link
Owner

pthom commented Dec 17, 2023

@Guillaume227 : lots of improvements were made for applications icons.

Please see https://github.com/pthom/hello_imgui_template/

@pthom pthom closed this as completed Dec 17, 2023
@Guillaume227
Copy link
Contributor Author

fantastic, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants