Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom: more unimplemented Opcodes #32

Closed
stormchaser3000 opened this issue Jul 5, 2021 · 11 comments
Closed

Zoom: more unimplemented Opcodes #32

stormchaser3000 opened this issue Jul 5, 2021 · 11 comments

Comments

@stormchaser3000
Copy link

stormchaser3000 commented Jul 5, 2021

61619|0xffff83f7ca05: Unimplemented Opcode (10) 66 0F 38 09 C1 66 0F 38 09 D3 66 0F 7F 07 66

this is after pulling in and compiling 81b1f61

EDIT: Thank you for all your work on this project. Keep up the good work, but don't overwork yourself :)

@stormchaser3000
Copy link
Author

That seems to have solved that error, but now getting this one:

67413|0xffff8e4939be: Unimplemented Opcode (01) 66 44 0F 38 09 C2 66 44 0F 38 09 D2 66 45 0F

with the same window freezing problem

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 6, 2021

Strange, that's the same opcode I just added.

@stormchaser3000
Copy link
Author

stormchaser3000 commented Jul 6, 2021

it is a different opcode as far as I can tell. many of the hex values are different from the first one

EDIT: Just a sec, I am going to pull in the latest changes and see if it works.

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 6, 2021

it's the same opcode.
It's "66 0F 38 09"
the 4x between 66 and 0F is the "REX", used to change a few parameters in the opcode, but it's still the same.

To be exact:
66 0F 38 09 C1: psignw xmm0, xmm1
66 44 0F 38 09 C2: psignw xmm8, xmm2

@stormchaser3000
Copy link
Author

oh... odd

@stormchaser3000
Copy link
Author

ok, an update fixed that one. but now there is this one (which I am actually pretty sure is different).

12825|0xffffac07e16c: Unimplemented Opcode (D3) 0F D7 CA 48 83 E1 0F 83 F1 0F 44 0F BD C1 BA

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 6, 2021

Yup, this one is different:
0F D7 CA: pmovmskb ecx, mm2

I'll add it soon.

@stormchaser3000
Copy link
Author

I can now report that zoom appears to be working like a charm on box64. Both audio and video work and the microphone works as well.

I will not close this issue just yet as I will do some stress testing in a large meeting tonight at some time around 9:30 PM CDT. If I don't encounter any missing opcodes during that meeting I will probably close this issue.

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 6, 2021

That's very good news! Especialy sound working, as that's still an issue on box86 with the 32bits version!

@Itai-Nelken
Copy link

I just tested on commit a5490dc (latest as of writing) on manjaro arm kde plasma running on aa pinebook pro and everything is working other than screen sharing (I'll open a new issue for that).
thanks a lot @ptitSeb!

@stormchaser3000
Copy link
Author

it is working quite well for me as well. I went to that meeting and besides the expected high CPU usage, it worked like charm. Thank you @ptitSeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants