Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error in -[RCTBatchedBridge loadSource:] when loading from .jsbundle #28

Closed
beretboat opened this issue Jan 15, 2016 · 5 comments
Closed

Comments

@beretboat
Copy link
Collaborator

I generate the bundle with command
curl 'http://localhost:8081/index.osx.bundle?platform=osx&dev=false&minify=true' -o main.jsbundle

The error message in Xcode console is:
"It looks like the implementation of DEV has changed. Update -[RCTBatchedBridge loadSource:]."

Similar error has been issued in react-native and resolved with 500ffa9. I tried the fix, it works for react-native-desktop too.

The thing is, I don't know how to sync or cherry pick changes from facebook/react-native. Suggestions?

@ptmt
Copy link
Owner

ptmt commented Jan 15, 2016

Thanks. Yeah, it has many of RN bugs, I will merge it with RN upstream (did it a few times already) once HotReload will finally get done.

@ptmt
Copy link
Owner

ptmt commented Jan 15, 2016

Does it really critical for you or you can wait for a week?
By the way there is no need to use curl, you can use react-native-desktop bundle cli or let XCode package bundle by itself with a build phase shell hook.

@beretboat
Copy link
Collaborator Author

Good to know. Thank you.
Before merging I will apply the fix locally. I know there's react-native-desktop bundle, but I'm not sure if it fully support OS X, because the --platform option in command help says it only accept "ios" or "android".
BTW this "HotReload" you mentioned, did you mean gaearon/react-hot-loader?

@ptmt
Copy link
Owner

ptmt commented Jan 31, 2016

@beretboat, it should be fixed now in 0.3.7. Yes, I mean react-hot-loader, which partially implemented now in react-native and therefore react-native-desktop.

@beretboat
Copy link
Collaborator Author

Just tested in latest build. Yes it's fixed, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants