Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab horizontal scroll overrides SliderIOS #3

Closed
anthony-liddle opened this issue Jun 24, 2015 · 3 comments
Closed

Tab horizontal scroll overrides SliderIOS #3

anthony-liddle opened this issue Jun 24, 2015 · 3 comments

Comments

@anthony-liddle
Copy link

I have the SliderIOS included in one of my views, and dragging the slider fires the scrollable tab view, making it impossible to move the slider handle.

@brentvatne
Copy link
Collaborator

Good point @anthony-liddle! I was a little greedy in taking the responder status anytime you swipe horizontally, so I went ahead and changed this so this component only takes over your swipe if you start it within edgeHitWidth px of the edges of your screen - this defaults to 30px, which is the iOS default for swiping back and same as what is used for the Navigator gestures. If you upgrade to 0.1.7 it should just work and you can configure that setting via the edgeHitWidth prop: https://github.com/brentvatne/react-native-scrollable-tab-view#props

If you're curious, this commit 255f5b3 is the one that fixes it

@anthony-liddle
Copy link
Author

You, sir, are awesome. Thank you!

@brendan-rius
Copy link

brendan-rius commented Jan 2, 2017

Is the fix still working? I have the same problem with 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants