Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

background-color is set overriding styles #2

Closed
simmel opened this issue Jul 31, 2017 · 2 comments
Closed

background-color is set overriding styles #2

simmel opened this issue Jul 31, 2017 · 2 comments

Comments

@simmel
Copy link

simmel commented Jul 31, 2017

When using styles with ptpb pbs.css overrides the background-color of the style that you choose.

E.g. see https://ptpb.pw/NFIm/perl?style=vim

The background color of pre is set to #f5f5f5 in pbs.css line 737. This overrides https://ptpb.pw/static/vim.css line 2.

I didn't find where the background color was set in less otherwise I would have PR'd it.

@buhman
Copy link
Member

buhman commented Aug 18, 2017

Yeah, I'm aware of this; I just never bothered to figure out how to fix it. The problem is the styles are shared with the index.rst rendering too, so just removing the background-color here could uglify things elsewhere.

background color was set

Woops; https://github.com/ptpb/pbs/blob/master/src/less/pbs/code.less#L10

@buhman
Copy link
Member

buhman commented Aug 18, 2017

I think I might have reasonably-ish fixed this in 103f9c6. That also removes the border though, which I think is less appealing than previously.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants