Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to edition 2021 #140

Closed
Eh2406 opened this issue Oct 31, 2023 · 2 comments
Closed

Move to edition 2021 #140

Eh2406 opened this issue Oct 31, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Eh2406
Copy link
Member

Eh2406 commented Oct 31, 2023

No description provided.

@Eh2406 Eh2406 added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 31, 2023
@0xAtticus
Copy link
Contributor

0xAtticus commented Nov 2, 2023 •
edited

I would like to work on it if that's possible.
@Eh2406 I created PR #142 , but I was expecting more things to do. Am I missing something ?

This was referenced Nov 2, 2023
Closed
Merged
@Eh2406
Copy link
Member Author

Eh2406 commented Nov 2, 2023

It is entirely possible that no other code changes required. To check, could you look through the addition guide at https://doc.rust-lang.org/edition-guide/rust-2021/index.html . For each thing that changed check whether it's relevant to our code base. If it is fix are code to the new idiom, if not comment on your PR why that change wasn't relevant.

Sorry, I should've put that description in this issue before I marked it good first issue.

@Eh2406 Eh2406 closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to edition 2021
2 participants
@Eh2406 @0xAtticus