Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency version with invalid direct dependencies should be tracked as incompatibility #151

Closed
zanieb opened this issue Nov 10, 2023 · 3 comments

Comments

@zanieb
Copy link
Member

zanieb commented Nov 10, 2023

Example at https://github.com/zanieb/pubgrub/blob/zanie/examples/examples/unsat_indirect_dependency_conflict_backtrack.rs

Given the following situation:

  • root depends on foo
  • foo 1.1 depends on bar 1.0
  • foo 1.2 depends on bar 1.0 and bar 2.0 (invalid)

The solver fails with an empty dependency set on foo 1.2.
Instead, the solver should mark foo 1.2 as incompatible(?) and backtrack to a valid version of foo such as 1.1.

@zanieb
Copy link
Member Author

zanieb commented Nov 10, 2023

In general, we need to be able to indicate that some package version does not have valid dependencies and should be ignored with a custom message for reports. I opened #152 to track that.

@Eh2406
Copy link
Member

Eh2406 commented Nov 10, 2023

The solver fails with an empty dependency set on foo 1.2.

Is this the DependencyOnTheEmptySet error? There is discussion about removing it in #125 and it was removed in #133, please try the dev branch and let me know if it's still a problem.

@zanieb
Copy link
Member Author

zanieb commented Nov 10, 2023

Ah thank you — I misunderstood the main branch in this project and have rebased my examples onto the dev branch.

This example indeed solves with dev.

@zanieb zanieb closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants