Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows slash #343

Closed
FlorianKoerner opened this issue Oct 29, 2017 · 2 comments
Closed

Windows slash #343

FlorianKoerner opened this issue Oct 29, 2017 · 2 comments

Comments

@FlorianKoerner
Copy link
Contributor

Windows use backslashes. So this condition failed.

rxdb/src/util.js

Lines 217 to 218 in ad79d1f

if (name.includes('/'))
return true;

@FlorianKoerner
Copy link
Contributor Author

FlorianKoerner commented Oct 29, 2017 •
edited

Probably not so relevant. See: https://superuser.com/questions/176388/why-does-windows-use-backslashes-for-paths-and-unix-forward-slashes/176395#176395

https://github.com/sindresorhus/slash

@pubkey pubkey closed this as completed in 58e1f30 Nov 1, 2017
@FlorianKoerner
Copy link
Contributor Author

Awesome. Thank you! 👍

@snyk-bot snyk-bot mentioned this issue Dec 18, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jul 14, 2021
Closed
@snyk-bot snyk-bot mentioned this issue Jul 21, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FlorianKoerner