Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the stringRotation solution you do nothing with rotation variable #1

Open
joaogomes44033 opened this issue Aug 13, 2017 · 0 comments

Comments

@joaogomes44033
Copy link

joaogomes44033 commented Aug 13, 2017

In the stringRotation solution you do nothing with rotation variable.

boolean stringRotation (String s1, String s2) { if (s1.length() == s2.length() && s1.length() > 0) { StringBuilder rotation = new StringBuilder(); rotation = s1+s1; return s2.isSubstring(s1); } return false; }

It should be:

return s2.isSubstring(rotation);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant