Using "id="primary" for series overview page messes up with primary widget area

[kuz-z-zma]

Wordpress themes use id="primary" to list css rules for main widget area, which usually is displayed in sidebar.

Current template for series overview page uses it to style section, which creates 2 instances of id (and html and css rules state, that there should only be onу per page), which makes page to fail markup validation and completely messes most designs, even when using Default option for display.

Styling of the Primary Widget Area, with id="primary"

Addition of second section using id="primary" results in this mess:

Yes, anyone with html editing skills can dig in and rename it, but most people still will be getting this unusable mess.

Please reconsider naming of the ids and classes.

[stevejburge]

Thanks for reporting this @kuz-z-zma

This is a legacy issue that may be a breaking change for some sites, but we'll take a look at it

[htmgarcia]

For reference, we have the primary id in two places:
https://github.com/publishpress/publishpress-series/blob/development/inc/templates/taxonomy-series.php#L20
https://github.com/publishpress/publishpress-series/blob/development/seriestoc.php#L19

@olatechpro is safe to just remove the id. What do you think?

[olatechpro]

Sincerely speaking, i won't have thought of themes using primary as sidebar ID. Default theme behaviour is wrapping page content inside id="primary", id="content" and sidebar in id="sidebar", id="primary-sidebar" etc. So, we're not totally wrong wrapping the page content inside id="primary" but we can do two things about this which is probably removing id attribute completely or otherwise, themes that use id="primary" for sidebar can simply copy the template to their theme and update accordingly.
If there are themes that use our template the way it is, they may have styling issue as well if we remove the wrapper styles.

So, it's left for us to determine what may be best here as dealing with frontend development is somehow critical than backend due to different theme with different behaviour and the best we can do is sticking to what we believe to be default.

For example, TOC template structure came from WordPress TwentyEleven theme which wrapped content inside id="primary"(saw it in one of the addon template)

@htmgarcia

[olatechpro]

Update: If you check 'twentytwentyone' WordPress theme header.php, content are wrapped inside primary. @htmgarcia

So, i think that's the best option we have unless we decided to remove ID attribute completely and give it a classname to enable people style the content.

Giving it random ID doesn't serve any value unless we style it in our plugin frontend css

[kuz-z-zma]

Personally, I believe using those broad names like "primary" by a plugin is just asking for trouble and can be easily avoided by using something like publish-series-primary for id naming. Also using those prefixes for all styling classes/ids make it easier to find and edit css files later on by users.

[htmgarcia]

@olatechpro I would think using exclusive classnames or ids is the best choice, however this requires some more thinking.

@kuz-z-zma we seems to agree on using custom classnames as an option. Please allow us some time to think about it.

[htmgarcia]

I prefixed the ids. It will be now "series-primary" and "series-content".
b589df6

[olatechpro]

Thanks @htmgarcia