Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize service worker from Url #369

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Apr 23, 2024

refactor(service-worker): initialize service worker from URL

Provider configuration option to set service worker from the URL (because of browser restrictions for worker files to be registered from the same domain).

Provider configuration option to set service worker from the URL (because of browser restrictions
for worker files to be registered from the same domain).
@parfeon parfeon added status: done This issue is considered resolved. priority: high This PR should be reviewed ASAP. type: refactor This PR contains refactored existing features. labels Apr 23, 2024
@parfeon parfeon self-assigned this Apr 23, 2024
*/
enableServiceWorker?: boolean;
serviceWorkerUrl?: string | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@parfeon
Copy link
Contributor Author

parfeon commented Apr 23, 2024

@pubnub-release-bot release

@parfeon parfeon merged commit 3fff075 into master Apr 23, 2024
7 checks passed
@parfeon parfeon deleted the refactor/service-worker/hosted-worker-path-setter branch April 23, 2024 10:33
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high This PR should be reviewed ASAP. status: done This issue is considered resolved. type: refactor This PR contains refactored existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants