Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AsyncioTelemetryManager to avoid creating a task every second #180

Closed
wants to merge 2 commits into from
Closed

Refactor AsyncioTelemetryManager to avoid creating a task every second #180

wants to merge 2 commits into from

Conversation

bdraco
Copy link

@bdraco bdraco commented Feb 18, 2024

fixes #179

@bdraco bdraco marked this pull request as ready for review February 19, 2024 05:23
@seba-aln seba-aln mentioned this pull request Feb 26, 2024
Merged
@seba-aln
Copy link
Contributor

seba-aln commented Feb 26, 2024 •
edited
Loading

Thanks for pointing this out and preparing solution!
Unfortunately we don't allow external PR's into our repository so I've copied your changes and created an internal PR so we can process it ad merge it

@seba-aln
Copy link
Contributor

Merged in #181.
Thanks again!

@seba-aln seba-aln closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

@jguz-pubnub jguz-pubnub Awaiting requested review from jguz-pubnub jguz-pubnub is a code owner

@wkal-pubnub wkal-pubnub Awaiting requested review from wkal-pubnub wkal-pubnub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncioTelemetryManager._start_clean_up_timer creates a new task every second
2 participants
@bdraco @seba-aln