Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc dep to v1.0.4 #46

Closed
douglas-reid opened this issue Dec 11, 2016 · 2 comments
Closed

Update grpc dep to v1.0.4 #46

douglas-reid opened this issue Dec 11, 2016 · 2 comments

Comments

@douglas-reid
Copy link
Contributor

Trying to build a go_proto_library with_grpc, got:

undefined: grpc.SupportPackageIsVersion4

This was fixed by manually adding:

new_go_repository(
    name = "org_golang_google_grpc",
    commit = "8712952b7d646dbbbc6fb73a782174f3115060f3",
    importpath = "google.golang.org/grpc",
)

to my WORKSPACE.

I believe the issue is that https://github.com/pubref/rules_protobuf/blob/master/go/deps.bzl#L26 is set to "tag": "v1.0.2" (instead of "tag": "v1.0.4" as needed).

From: https://github.com/grpc/grpc-go/releases/tag/v1.0.4

Now the grpc support version is SupportPackageIsVersion4

@pcj
Copy link
Contributor

pcj commented Dec 11, 2016

Thanks @douglas-reid, required updating golang/protobuf as well as grpc/grpc-go for SupportPackageIsVersion4. Please re-open if you are still encountering issues. PR's also welcome in the future to get you in the contributors list.

@douglas-reid
Copy link
Contributor Author

Many thanks, @pcj ! Switched to your latest commit and everything works.

You got to it before I could even get around to starting a PR to confirm the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants