Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git tests fail when building v0.8.3 on nixos #242

Open
guillaumecherel opened this issue Aug 21, 2020 · 2 comments
Open

Git tests fail when building v0.8.3 on nixos #242

guillaumecherel opened this issue Aug 21, 2020 · 2 comments

Comments

@guillaumecherel
Copy link

I tried upgrading the pubs nixos package to version 0.8.3, but git tests fail. It seems to be related to the tests relying on a pre-configured git, which does not happen on nix. All details are available here.

Can you do anything about it?

@benureau
Copy link
Contributor

Indeed, git will complain when not configured, which throws the tests out... we could protect the tests by testing if git is configured first, and expect them to fail it it isn't. I will look into it. The issue on nixos seems resolved though?

@guillaumecherel
Copy link
Author

Yes, the solution accepted on nixos is just to disable the git tests by deleting the tests_git.py file before building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants