Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSubHubbub Core 0.4: Verifying during subscription request #28

Closed
cweiske opened this issue Mar 11, 2015 · 1 comment
Closed

PubSubHubbub Core 0.4: Verifying during subscription request #28

cweiske opened this issue Mar 11, 2015 · 1 comment

Comments

@cweiske
Copy link
Contributor

cweiske commented Mar 11, 2015

Is it allowed to do the validation and verification of intent
process while the subscription request is running?

This would imply that the verification of intent callback and the
denied-callback is called when while the subscription request is still
being answered.

That would make it possible to skip all the worker setup that's
necessary to do delayed validation and verification.

Process diagram for inline validation:

client                     server/hub
 +---[subscription request]-->-----+
 |                                 |
 |  +<--[verification of intent]---+
 |  |
 |  +--[verification response]-->--+
 |                                 |
 |  +<--[denied callback]----------+
 |  |
 |  +----[response]------------->--+
 |                                 |
 +--<--[subscription response]-----+

This would also make it possible to not call the callback at all but
tell the denied-state directly in the response of the subscription
request. But that does not seem to be planned at all, right?

@julien51
Copy link
Member

Is it allowed to do the validation and verification of intent
process while the subscription request is running?

No. We decided to remove the complexity of having 2 modes (async or sync -which you're describing). Sync was also creating issues in the context of application unable to handle more than one concurrent requests (GAE, Rails dev, Heroku applications... etc).

Also, the validation is inherently async because the publisher can take days before confirming that subscription is allowed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants