Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Error updating device" where name contains quote character #42

Closed
BananaHammock743 opened this issue Jan 18, 2021 · 4 comments
Closed
Assignees
Labels
bug Something isn't working fixed Bug fixed

Comments

@BananaHammock743
Copy link

Pi.alert 2.52 (2021-01-11)

On the device info page (/pialert/deviceDetails.php?mac=<MAC>) where you can update the name etc of a device, if you enter a quote " you get an error on save. See example below where name includes a single "

image

@pucherot
Copy link
Owner

Thanks. At the moment, you can use single quotes.
In future version this issue will be solved.

@pucherot pucherot self-assigned this Jan 18, 2021
@pucherot pucherot added the bug Something isn't working label Jan 18, 2021
@sml156
Copy link

sml156 commented Jan 26, 2021

It seems that quotes are not valid character, Check out the RFC

https://man7.org/linux/man-pages/man7/hostname.7.html
This is something you probably should not fix, I think even single quote are invalid, separate names with a " - " if you have too.

not following the RFC may cause problems on other devices on your network -- especially on your gateway router

search google for " valid hosts names "

@pucherot
Copy link
Owner

Solved in next version

@BananaHammock743
Copy link
Author

🙌

@pucherot pucherot added the fixed Bug fixed label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Bug fixed
Projects
None yet
Development

No branches or pull requests

3 participants