Can't handle multibyte chars correctly

[heavenshell]

Hi. Thank you for create nice library.

I've got multibyte problem.

If MySQL's charset is utf8, SQLAlchemy's database connection url should set like following.
mysql://foo:foo_password@localhost/bar_table?charset=utf8&use_unicode=0

Currently, database.py ignore url query string.
So, dataset can't handle multibyte correctly.
SQLAlchemy convert to multibyte char to ? automatically.

--- database.py.orig    2013-11-16 00:55:53.000000000 +0900
+++ database.py 2013-11-16 00:55:46.000000000 +0900
@@ -24,6 +24,7 @@
         kw['poolclass'] = NullPool
     self.lock = threading.RLock()
     self.local = threading.local()
+       original_url = url
     if '?' in url:
         url, query = url.split('?', 1)
         query = parse_qs(query)
@@ -33,7 +34,7 @@
             if len(schema_qs):
                 schema = schema_qs.pop()
     self.schema = schema
-        engine = create_engine(url, **kw)
+       engine = create_engine(original_url, **kw)
     self.url = url
     self.engine = construct_engine(engine)
     self.metadata = MetaData(schema=schema)

Is there any reason to ignore url query?
IMHO dataset should not ignore url query for handling multibyte.

Regards.

[pudo]

Yeah, overloading the URL query string to handle dataset arguments was probably a stupid move. I'll try and refactor to leave the non-specific bits of the query string intact. Thanks for pointing it out!

[heavenshell]

Awesome! Thank you!