update/updsert will delete keys in row?

[hszcg]

hi folks,

I just found that in https://github.com/pudo/dataset/blob/master/dataset/persistence/table.py#L128

we actually delete keys in the row, e.g.

c = {'id':1, 'val':'name'}
table.upsert(c, ['id'])
# NOW c == {'val': 'name'} HERE!

is there anyway to avoid this?
i mean keeping c unchanged after calling update/upsert.

Thanks.

[pudo]

Thanks for reporting this, it'll be in the next release.

[hszcg]

@pudo

Thanks for the quick hands.
Personally, I would suggest that maybe you could use the following code instead, which might be more efficient.

clean_row = row.copy()
for key in keys:
    if key in clean_row.keys():
        del clean_row[key]

Just a suggestion, totally up to you, thanks.

[pudo]

Changed it accordingly, thanks for the pointer.

[hszcg]

@pudo

Actually, I mean row.copy() rather than copy.copy(row), which is way more efficient.
Please check the performance benchmark on http://stackoverflow.com/a/5861653/1143054

Thanks,