Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch Request] Porting some patches for getting great performance #5

Closed
NovaPixell opened this issue Dec 4, 2021 · 1 comment
Closed

Comments

@NovaPixell
Copy link

NovaPixell commented Dec 4, 2021

In the previous issue I mentioned the server I manage. We have a large amount of entities and tile entities, it would be interesting to have patches on Pufferfish that optimize these.

Patina, a very good and stable software, in 1.17 offers these stable patches:

  1. lithium-entity.fast_retrieval.patch - lithium-entity.fast_retrieval.patch
  2. New-nbt-cache.patch
  3. Optimize-TileEntity-load-unload.patch
  4. Item-stuck-sleep.patch

The third patch is very useful for servers that have high amounts of TE.

Please consider adding these patches, so that our servers will enjoy high performance!

@kev626
Copy link
Member

kev626 commented Dec 5, 2021

I will only add patches if they have been proven (with proper profiling) to improve performance, and that the thing they claim to improve has been proven (with proper profiling) to be an actual performance problem.

I have not been shown evidence of any of these patches satisfying both of these requirements, so they will not be included in Pufferfish.

@kev626 kev626 closed this as completed Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants