Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add java 19 support #54

Closed
AVuTuVA opened this issue Nov 22, 2022 · 2 comments
Closed

Please add java 19 support #54

AVuTuVA opened this issue Nov 22, 2022 · 2 comments

Comments

@AVuTuVA
Copy link

AVuTuVA commented Nov 22, 2022

https://github.com/pufferfish-gg/Pufferfish/blob/ver/1.19/patches/server/0004-Add-SIMD-utilities.patch
SIMDDetection.versionLimited = SIMDDetection.getJavaVersion() < 17;

@kev626
Copy link
Member

kev626 commented Nov 22, 2022

Your suggested change is not sufficient as the SIMD functions we are using are in incubation for Java 17 and Java 18. Meaning that they are not guaranteed to work on future Java versions (which is why this disables itself on new Java versions -- this is very intentional as to not break things should these APIs change). Because this is an incubating feature, it is a matter of time before the packages that this patch relies upon are removed, so we cannot simply say "support all Java versions" unchecked.

I will investigate support for Java 19 and future Java versions separately because, as I explained before, these are not guaranteed to be compatible post-Java 19.

@kev626
Copy link
Member

kev626 commented Dec 18, 2022

Completed in 394f21f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants