StringPlusAny still problematic

[ritschwumm]

"" + { val x = ""; if (true) x else x }

and

Set("") + ""

both trigger

Implicit conversion to string is disabled

[Fristi]

Can confirm Implicit conversion to string is disabled is problematic on string sets

[seanmcl]

+1

[ritschwumm]

i played with this for a bit..

Set("") + "" may be fixable by having a better mechanism to figure out the type of Set(""). at the moment it seems to be stumbling over the fact that the owner of the apply method in Set.apply("") is GenericCompanion and looks there for an overloaded + method.

"" + { val x = ""; if (true) x else x } looks more difficult - for some reason, the type of { val x = ""; if (true) x else x } is reported as Any...

[ClaireNeveu]

I preserved the old Any2StringAdd behavior in the wart, so we should be able to fix the Set problem by just checking when the left-hand type is String and ignoring cases where only the right-hand type is String.

As for the other issue, we probably need more investigation into what is wrong with the reflection api here but users can fix it with explicit typing.

[ritschwumm]

i probably should have opened two separate issues...