Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the PUT /case endpoint to be a PATCH instead. #17

Open
benjaminkostiuk opened this issue Jul 25, 2021 · 0 comments
Open

Fix the PUT /case endpoint to be a PATCH instead. #17

benjaminkostiuk opened this issue Jul 25, 2021 · 0 comments
Labels
bug Something isn't working priority:low Low priority work item
Projects
Puff Platform

Comments

@benjaminkostiuk
Copy link
Member

Since the endpoint only allows updating certain fields instead of the entire object + we already specify the id in the url it conforms to the standards of a PATCH request instead of a PUT request. Make sure the validation is correct & write a test case to make sure only the right fields are getting updated.
@benjaminkostiuk benjaminkostiuk added priority:low Low priority work item bug Something isn't working labels Jul 25, 2021
@benjaminkostiuk benjaminkostiuk added this to To do in Puff Platform via automation Jul 25, 2021
@benjaminkostiuk benjaminkostiuk changed the title Fix the PUT /case endpoint to be a PATH instead. Fix the PUT /case endpoint to be a PATCH instead. Aug 4, 2021
@benjaminkostiuk benjaminkostiuk moved this from To do to In progress in Puff Platform Sep 2, 2021
@benjaminkostiuk benjaminkostiuk moved this from In progress to To do in Puff Platform Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:low Low priority work item
Projects
Puff Platform
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youcefs21 @benjaminkostiuk