Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java support for suite files + test suites #24

Open
benjaminkostiuk opened this issue Aug 22, 2021 · 2 comments
Open

Add Java support for suite files + test suites #24

benjaminkostiuk opened this issue Aug 22, 2021 · 2 comments
Assignees
Labels
feature Feature or improvement priority:high High priority work item

Comments

@benjaminkostiuk
Copy link
Member

Similar to #6, since it was closed with the addition of Haskell support.
Same procedure should work great, my only concern is really the Docker image size. I have Python down to 50mb, it would be nice to keep the Java image under 200 mb if possible.

@benjaminkostiuk benjaminkostiuk added feature Feature or improvement priority:high High priority work item labels Aug 22, 2021
@benjaminkostiuk benjaminkostiuk added this to To do in Puff Platform via automation Aug 22, 2021
@benjaminkostiuk benjaminkostiuk moved this from To do to In progress in Puff Platform Aug 25, 2021
@OZoneGuy
Copy link
Contributor

Hey, I am getting back to this issue. One thing I wanted your feedback on is how to include the JUnit jar. I can either bake it into the image, download it and place it during building, or mount it. The latter seems like the better idea, but the issue being is how to copy it. Unless we want to add special code in the Java case that specifically copies the jar into the WORKDIR I don't see a good way of doing it.

I suppose what is also relevant is if other jar files are required for assignments. But I suppose we can handle that in a later iteration?...

I will start with the mounting approach and see where it goes, since it looks like the most time-consuming.

@benjaminkostiuk
Copy link
Member Author

Sure whatever you think works best! I'm not against baking it into the image itself if it's small enough considering we won't be building images on every test case once I refactor the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature or improvement priority:high High priority work item
Projects
Puff Platform
In progress
Development

No branches or pull requests

2 participants