Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Contact Us Title not displaying on front end. #181

Closed
laranz opened this issue Mar 19, 2017 · 10 comments
Closed

[Bug] Contact Us Title not displaying on front end. #181

laranz opened this issue Mar 19, 2017 · 10 comments
Assignees

Comments

@laranz
Copy link

laranz commented Mar 19, 2017

In line #24 and #42 in /wp-content/themes/illdy/sections/front-page-contact-us.php

The title variable is wrongly getting, it should be

$general_title = get_theme_mod( 'illdy_contact_us_title', __( 'Contact us', 'illdy' ) );
and
$general_title = get_theme_mod( 'illdy_contact_us_title' );

We had a word general.

@cristianraiber
Copy link
Member

@giucu91 - please see this.

giucu91 added a commit to WPChill/illdy that referenced this issue Mar 20, 2017
@thiagovilla
Copy link

This worked for me!

@thiagovilla
Copy link

Also, removing "general_" from the address and customer support titles solved the issue for these variables.

@laranz
Copy link
Author

laranz commented Mar 26, 2017

@thiagoth23 Yeah, it will be fixed in the next version. 👍

@LuigiBella
Copy link

@laranz or @thiagoth23 Could you please describe in detail how to fix it in the meantime?
You can see the issue at my domain here: http://www.bradfordcowork.com

Thanks so much!

@thiagovilla
Copy link

@LuigiBella it's been a while since I last did this. Do you have the front-page-contact-us.php original file on yourself? Attach it here and I can take a look.

@LuigiBella
Copy link

@thiagoth23 Thanks so much for replying, I managed a work around but would love to find why it broke in the first place.

To get the About and Contact Us titles to display I went to the Customizer and changed the default text from About to "- About -", I did the same thing for the Contact Title.

Here is the original file from version 1.0.35; version 2.0 brought a whole other array of issues such as breaking the customizer, removing the background of the contact form, and changing the footer so I went back to version 1.0.35 and can get the customizer working as long as I disable the Illdy Companion plugin:

front-page-contact-us.php.zip

@thiagovilla
Copy link

Yikes! I hate it when a newer version screws up more than the previous one!

Uhm, let's see! Okay, so here's lines 24-28:

$general_title = get_theme_mod( 'illdy_contact_us_general_title', __( 'Contact us', 'illdy' ) );
$general_entry = get_theme_mod( 'illdy_contact_us_general_entry', __( 'And we will get in touch as soon as possible.', 'illdy' ) );
$general_contact_form_7 = get_theme_mod( 'illdy_contact_us_general_contact_form_7' );
$general_address_title = get_theme_mod( 'illdy_contact_us_general_address_title', __( 'Address', 'illdy' ) );
$customer_support_title = get_theme_mod( 'illdy_contact_us_general_customer_support_title', __( 'Customer Support', 'illdy' ) );

And 42-46:

$general_title = get_theme_mod( 'illdy_contact_us_general_title' );
$general_entry = get_theme_mod( 'illdy_contact_us_general_entry' );
$general_contact_form_7 = get_theme_mod( 'illdy_contact_us_general_contact_form_7' );
$general_address_title = get_theme_mod( 'illdy_contact_us_general_address_title' );
$customer_support_title = get_theme_mod( 'illdy_contact_us_general_customer_support_title' );

FIX

What I did the last time was remove the "general_" prefix from WITHIN the get_theme_mod method, NOT the variable name! See:

BEFORE:

$general_title = get_theme_mod( 'illdy_contact_us_general_title', __( 'Contact us', 'illdy' ) );

AFTER:

$general_title = get_theme_mod( 'illdy_contact_us_title', __( 'Contact us', 'illdy' ) );

captura de tela de 2017-06-27 08-55-23

So here's your file with the "general_" prefix removed from lines 24-28, 42-46. Try it and let me know if it worked.

front-page-contact-us.php.zip

@LuigiBella
Copy link

@thiagoth23 Once again, thank you!
but strangely enough, it doesn't appear to have worked; here is what happened:
screen shot 2017-06-27 at 3 19 37 pm

and you can see the website with the original script here: bradfordcowork.com

@thiagovilla
Copy link

thiagovilla commented Jun 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants