Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on travis fail because of puli #176

Open
gossi opened this issue Jan 14, 2016 · 6 comments
Open

Tests on travis fail because of puli #176

gossi opened this issue Jan 14, 2016 · 6 comments

Comments

@gossi
Copy link

gossi commented Jan 14, 2016

I realized, tests on travis are failing because of puli. Here is a travis log: https://travis-ci.org/keeko/core/jobs/102379958

Seems like that happens because a puli-cli is missing?

@webmozart
Copy link
Member

Hi @gossi :) Did you try adding puli/cli as dev dependency?

@gossi
Copy link
Author

gossi commented Feb 2, 2016

Nope, and doing so would feel wrong.

@webmozart
Copy link
Member

@gossi Then you need to adjust your build script to install Puli by running:

curl https://puli.io/installer | php

@gossi
Copy link
Author

gossi commented Feb 2, 2016

Nope, wrong, too. Every I need to do is a workaround to cope with a puli problem. My tests run fine, when everything is installed, yet puli prevents this install. I expect puli to be clever enough to skip it's own installation mechanism, when its required dependencies are not present. Well, at least that it doesn't break other's code with a Fatal Error but degrade gracefully with a warning or something equivalent.

@webmozart
Copy link
Member

Ah, I just saw the fatal error in the log. That's a bug indeed. The install should proceed after the warning.

@Spomky
Copy link

Spomky commented Apr 26, 2016

Hi,

Is there any news regarding this issue.
It does not work for me as well (see https://travis-ci.org/Spomky-Labs/OAuth2ServerBundle/jobs/125765205).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants