Remove code related to contributor agreements. Closes #8

app/assets/javascripts/worthwhile/worthwhile.js

@@ -5,7 +5,6 @@
 //= require worthwhile/link_groups
 //= require worthwhile/proxy_rights
 //= require worthwhile/facet_mine
-//= require worthwhile/accept_contributor_agreement
 //= require worthwhile/proxy_submission
 //= require worthwhile/embargoes
 
@@ -42,4 +41,3 @@ Blacklight.onLoad(function() {
   $("[data-toggle='dropdown']").dropdown();
 
 });
-

app/assets/stylesheets/worthwhile/_typography.scss

@@ -77,8 +77,7 @@ legend {
   font-weight:normal;
 }
 
-.redacted,
-.unratified .contributor_agreement p {
+.redacted {
   font-family:'BLOKKNeue-Regular';
 }
 
@@ -105,10 +104,6 @@ legend {
   text-align:center;
 }
 
-.contributor_agreement.human_readable {
- font-size:150%;
-}
-
 .doi {
   font-size:200%;
   margin:1em 0;

app/controllers/concerns/worthwhile/curation_concern_controller.rb

@@ -10,7 +10,6 @@ module Worthwhile::CurationConcernController
     class_attribute :curation_concern_type
     attr_accessor :curation_concern
     helper_method :curation_concern
-    helper_method :contributor_agreement
 
     respond_to :html
   end
@@ -26,16 +25,12 @@ def cancan_resource_class
     end
   end
 
-  def contributor_agreement
-    @contributor_agreement ||= Worthwhile::ContributorAgreement.new(curation_concern, current_user, params)
-  end
-
 
   def new
   end
 
   def create
-    return unless verify_acceptance_of_user_agreement!
+    # return unless verify_acceptance_of_user_agreement!
     if actor.create
       after_create_response
     else
@@ -83,19 +78,19 @@ def setup_form
       end
     end
 
-    def verify_acceptance_of_user_agreement!
-      return true if contributor_agreement.is_being_accepted?
-      # Calling the new action to make sure we are doing our best to preserve
-      # the input values; Its a stretch but hopefully it'll work
-      self.new
-      respond_with(:curation_concern, curation_concern) do |wants|
-        wants.html {
-          flash.now[:error] = "You must accept the contributor agreement"
-          render 'new', status: :conflict
-        }
-      end
-      false
-    end
+    # def verify_acceptance_of_user_agreement!
+    #   return true if contributor_agreement.is_being_accepted?
+    #   # Calling the new action to make sure we are doing our best to preserve
+    #   # the input values; Its a stretch but hopefully it'll work
+    #   self.new
+    #   respond_with(:curation_concern, curation_concern) do |wants|
+    #     wants.html {
+    #       flash.now[:error] = "You must accept the contributor agreement"
+    #       render 'new', status: :conflict
+    #     }
+    #   end
+    #   false
+    # end
 
     def _prefixes
       @_prefixes ||= super + ['curation_concern/base']

app/views/curation_concern/base/_form.html.erb

@@ -1,5 +1,5 @@
 <%= simple_form_for [:curation_concern, curation_concern] do |f| %>
-  
+
   <% if f.error_notification -%>
     <div class="alert alert-danger fade in">
       <strong>Wait don't go!</strong> There was a problem with your submission. Please review the errors below:
@@ -11,8 +11,6 @@
 
   <%= render 'form_supplementary_fields', curation_concern: curation_concern, f: f %>
 
-  <%= render 'form_contributor_agreement', curation_concern: curation_concern, contributor_agreement: contributor_agreement %>
-
   <div class="row">
     <div class="col-md-12 form-actions">
       <%= f.submit class: 'btn btn-primary require-contributor-agreement' %>

spec/controllers/curation_concern/generic_works_controller_spec.rb

@@ -20,7 +20,7 @@
       let(:a_work) { FactoryGirl.create(private_work_factory_name) }
       it "should redirect and show unauthorized message" do
         get :show, id: a_work
-        expect(response).to fail_redirect_and_flash(root_path, 'You are not authorized to access this page.') 
+        expect(response).to fail_redirect_and_flash(root_path, 'You are not authorized to access this page.')
       end
     end
 
@@ -54,7 +54,7 @@
   describe "#create" do
     it "should create a work" do
       expect {
-        post :create, accept_contributor_agreement: "accept", generic_work: { title: ["a title"] }
+        post :create, generic_work: { title: ["a title"] }
       }.to change { GenericWork.count }.by(1)
       expect(response).to redirect_to [:curation_concern, assigns[:curation_concern]]
     end

spec/features/embargo_spec.rb

@@ -16,7 +16,6 @@
     it "can be created, displayed and updated" do
       click_link 'New Generic Work'
       fill_in 'Title', with: 'Embargo test'
-      check 'I have read and accept the contributor license agreement'
       choose 'Embargo'
       fill_in "generic_work_embargo_release_date", with: future_date
       select 'Private', from: 'Restricted to'

spec/features/lease_spec.rb

@@ -14,7 +14,6 @@
       visit '/'
       click_link 'New Generic Work'
       fill_in 'Title', with: 'Lease test'
-      check 'I have read and accept the contributor license agreement'
       choose 'Lease'
       fill_in "generic_work_lease_expiration_date", with: future_date
       select 'Open Access', from: 'Is available for'