Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to blacklight 8 #346

Open
hackartisan opened this issue Jan 30, 2023 · 2 comments
Open

Upgrade to blacklight 8 #346

hackartisan opened this issue Jan 30, 2023 · 2 comments

Comments

@hackartisan
Copy link
Member

hackartisan commented Jan 30, 2023

Initially this is experimental in service of the blacklight committers' release effort.

@eliotjordan
Copy link
Member

eliotjordan commented Jan 30, 2023

Deprecation warnings on BL 7.33.0:

  • Initializing a Blacklight::Configuration::ViewConfig implicitly (by calling masonry) is deprecated. Call it as masonry! or pass initialize arguments. (called from block in class:CatalogController at /Users/eliotj/Documents/Repositories/lae-blacklight/app/controllers/catalog_controller.rb:11) note: changing this to config.view.masonry! works but the hover interaction in the masonry view looks very bad. We have not yet updated blacklight-gallery -- see how that impacts visually.
  • render_search_bar is deprecated and will be removed from a future release (Call render Blacklight::SearchBarComponent.new instead). (called from _app_views_shared__header_navbar_html_erb___903966786867993672_57000 at /Users/eliotj/Documents/Repositories/lae-blacklight/app/views/shared/_header_navbar.html.erb:27) NOTE: This new takes arguments, deprecation warning does not advise, we used https://github.com/projectblacklight/blacklight/blob/main/app/views/catalog/_search_form.html.erb as a reference.
  • search_bar_presenter is deprecated and will be removed from a future release. (called from render_search_bar at /Users/eliotj/.asdf/installs/ruby/3.1.0/lib/ruby/gems/3.1.0/gems/blacklight-7.33.0/app/helpers/blacklight/blacklight_helper_behavior.rb:92) NOTE: this one went away when we put in the SearchBarComponent
  • render is deprecated and will be removed from a future release (The SearchBarPresenter has been deprecated. Call `render Blacklight::SearchBarComponent.new' instead). (called from render_search_bar at /Users/eliotj/.asdf/installs/ruby/3.1.0/lib/ruby/gems/3.1.0/gems/blacklight-7.33.0/app/helpers/blacklight/blacklig
    ht_helper_behavior.rb:92) NOTE: this one went away when we put in the SearchBarComponent
  • render_hash_as_hidden_fields is deprecated and will be removed from a future release (Use Blacklight::HiddenSearchStateComponent instead). (called from block in _app_views_catalog__search_form_html_erb___1693512011722287808_57080 at /Users/eliotj/Documents/Repositories/lae-blacklight/app/views/catalog/_search_form
    .html.erb:2) -- see pulibrary/orangelight@98a6b1a -- NOTE: went away when we put in the SearchBarComponent -- removed the search_form partial entirely.
  • search_field_options_for_select is deprecated and will be removed from a future release (removed without replacement). (called from search_fields at /Users/eliotj/.asdf/installs/ruby/3.1.0/lib/ruby/gems/3.1.0/gems/blacklight-7.33.0/app/helpers/blacklight/configuration_helper_behavior.rb:25) -- NOTE: don't see this one anymore
  • should_autofocus_on_search_box? is deprecated and will be removed from blacklight 8.0 (use SearchBarPresenter#autofocus?). (called from block in _a
    pp_views_catalog__search_form_html_erb___1693512011722287808_57080 at /Users/eliotj/Documents/Repositories/lae-blacklight/app/views/catalog/_search_form.html.erb:14) -- NOTE: went away when we put in the SearchBarComponent -- removed the search_form partial entirely.
  • Blacklight 8 will filter out non-search parameter, including: id and locale. (called from permit_search_params at /Users/eliotj/.asdf/installs/ruby/3.1.0/lib/ruby/gems/3.1.0/gems/blacklight-7.33.0/lib/blacklight/parameters.rb:77) -- see pulibrary/orangelight@9e14e50
  • The partial _previous_next_doc.html.erb will be removed in 8.0. Render Blacklight::SearchContextComponent instead. (called from public_send at /Users/eliotj/.asdf/installs/ruby/3.1.0/lib/ruby/gems/3.1.0/gems/actionview-6.1.7.2/lib/action_view/base.rb:247)
  • document_show_html_title is deprecated and will be removed from a future release (Use Blacklight::DocumentPresenter#html_title instead). (called from _app_views_catalog_show_html_erb__4229276877115597867_57440 at /Users/eliotj/Documents/Repositories/lae-blacklight/app/views/catalog/show.html.erb:5) -- see pulibrary/orangelight@9680421
  • render_document_heading is deprecated and will be removed from a future release (Removed without replacement). (called from _app_views_catalog__show_header_default_html_erb__1161563450038325294_57520 at /Users/eliotj/Documents/Repositories/lae-blacklight/app/views/catalog/_show_header_default.html.erb:2)
  • he @document_list instance variable is now deprecated and will be removed in Blacklight 8.0 (called from block (3 levels) in <top (required)> at /Users/eliotj/Documents/Repositories/lae-blacklight/spec/request/bookmarks_controller_spec.rb:9)
  • Calling render_document_index without documents is deprecated and will be removed in version 8. (called from _app_views_bookmarks_index_html_erb___393395178377545216_64440 at /Users/eliotj/Documents/Repositories/lae-blacklight/app/views/bookmarks/index.html.erb:15)

@hackartisan
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants